bitflicker64 commented on PR #3105: URL: https://github.com/apache/hugegraph/pull/3105#issuecomment-5077313616
Pushed a follow-up addressing the outstanding threads on the current head. Status per open item: **Fixed:** - [Endpoint/dual-stack conflict semantics](https://github.com/apache/hugegraph/pull/3105#discussion_r3645160690) — kept as-is intentionally. Treating IPv4/IPv6 wildcard binds as a conflict is conservative (fails safe: blocks startup on a legitimate coexisting bind rather than missing a real conflict). Left the existing code comment explaining the tradeoff; happy to make this dual-stack-aware in a follow-up if you would rather not carry the false-positive risk. - [`fuser` cleanup remains unenforced](https://github.com/apache/hugegraph/pull/3105#discussion_r3645160703) — this was already addressed in `8307426`: `server-ci.yml` now gates on `fuser` for non-Darwin runners in the preflight step, and `test-start-hugegraph*.sh` warns explicitly when neither `fuser` nor `lsof` is available instead of silently no-opping. - `download()` missing directory creation on the `wget` path — the earlier fix only covered `curl` (added `mkdir -p` + `basename`). Applied the same guard to the `wget` branch in all three `util.sh` files (server, PD, store) for consistency. **Documented, not changed:** - Unbracketed IPv6 (`::1:8080` without brackets) would still misparse in `check_port` authority extraction. Confirmed `ServerOptions`/`HugeConfig` only trims whitespace and prefixes a default scheme — it does not enforce bracket notation, so this is not provably unreachable. Added a comment at the parse site documenting the assumption and the failure mode, so it does not need rediscovering. Low blast radius since it only affects the pre-flight check, not the actual bind. Re-requesting review on the latest commit — let me know if any of the above needs more than a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
