VGalaxies commented on code in PR #366:
URL: https://github.com/apache/hugegraph-ai/pull/366#discussion_r3469375990
##########
.github/workflows/ruff.yml:
##########
@@ -40,7 +40,7 @@ jobs:
- name: Install dev dependencies
run: |
- uv sync --extra dev
+ uv sync --extra dev --extra llm --extra python-client
Review Comment:
**High: Python 3.12 job cannot install the LLM extra**
`.github/workflows/ruff.yml:43`
**Evidence**
- The workflow matrix still includes `python-version: ["3.10", "3.11",
"3.12"]` at `.github/workflows/ruff.yml:15`, while the changed install step now
runs `uv sync --extra dev --extra llm --extra python-client`;
`hugegraph-llm/pyproject.toml:30` declares `requires-python = ">=3.10,<3.12"`.
**Impact**
- The Python 3.12 Ruff job can fail during dependency resolution/install,
making the workflow blocking before `continue-on-error: true` on the `ty` step
can apply.
**Requested fix**
- Keep the Python 3.12 Ruff job on a Python-3.12-compatible install, or
split the `llm`/`ty` install and check into a separate non-blocking job or
matrix limited to Python 3.10 and 3.11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
