imbajin commented on code in PR #366:
URL: https://github.com/apache/hugegraph-ai/pull/366#discussion_r3452770661
##########
.github/workflows/ruff.yml:
##########
@@ -49,3 +49,9 @@ jobs:
- name: Lint code with Ruff
run: |
uv run ruff check .
+
+ - name: Type check with ty (non-blocking)
+ run: uv run ty check hugegraph-llm/src hugegraph-python-client/src
Review Comment:
⚠️ **Install the checked packages before running ty**
The workflow only runs `uv sync --extra dev`, then type-checks
`hugegraph-llm/src` and `hugegraph-python-client/src`. Replaying that sequence
on this head makes `uv run ty check ...` emit 838 diagnostics, starting with
unresolved `fastapi`, `pydantic`, and `dotenv`, because the LLM/client runtime
extras are not installed. Please sync the extras needed by the checked source,
for example `uv sync --extra dev --extra llm --extra python-client`, or narrow
the command to code whose dependencies are present, so the non-blocking report
is actionable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
