imbajin commented on PR #349: URL: https://github.com/apache/hugegraph-computer/pull/349#issuecomment-4762040175
❗️ Please also update the CI HugeGraph environment after fixing the parser. 🔗 Reference: [`computer-ci.yml`](https://github.com/apache/hugegraph-computer/blob/60bb1b659cdd23089fd37ca542a18e68d9cf8225/.github/workflows/computer-ci.yml#L25-L27) **Context** - The current workflow still runs integration tests with `GRAPH_ENV_VERSION: 1.3.0`. - The adjacent TODO still says to adapt Server/Loader to `1.5.0`, but the current release line is already `1.7.0`. - `GRAPH_ENV_VERSION` is passed into `load-data-into-hugegraph.sh`, which starts both: - `hugegraph/hugegraph:${GRAPH_ENV_VERSION}` - `hugegraph/loader:${GRAPH_ENV_VERSION}` **Required update** Please update the workflow to use the latest `1.7.0` HugeGraph Server/Loader images and remove the stale TODO, for example: ```yaml GRAPH_ENV_VERSION: 1.7.0 ``` **Test completeness** After that, the related coverage should prove both compatibility directions: - unit tests cover legacy 4-part edge ids; - unit tests cover current 5/6-part edge ids; - CI integration tests actually load data through HugeGraph Server/Loader `1.7.0`, so this PR is validated against the permanent edge-id format rather than only the old `1.3.0` environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
