hutiefang76 opened a new pull request, #349:
URL: https://github.com/apache/hugegraph-computer/pull/349
## Purpose of the PR
- close #324
HugeGraph server now formats edge ids with 5 or 6 parts after the
parent/child edge label change. The computer loader still called `Edge.name()`
from the older client, which expects exactly 4 parts and can fail while loading
edges for algorithms such as LPA.
## Main Changes
- Add `HugeConverter.convertEdgeName()` to read sort values from 4-part,
5-part, and 6-part edge ids.
- Use the converter in `LoadService` instead of calling `edge.name()`
directly.
- Add regression coverage for both 5-part and 6-part edge id formats.
## Verifying these changes
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests
here)*.
- [x] Need tests and can be verified as follows.
```bash
mvn -pl computer-test -am -Djacoco.skip=true \
-Dtest=HugeConverterTest#testConvertEdgeNameWithFivePartEdgeId+testConvertEdgeNameWithSixPartEdgeId
\
-Dsurefire.failIfNoSpecifiedTests=false test
mvn -pl computer-test -am -Djacoco.skip=true \
-Dtest=HugeConverterTest \
-Dsurefire.failIfNoSpecifiedTests=false test
```
## Does this PR potentially affect the following parts?
- [x] Nope
- [ ] Dependencies (add/update license info)
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
## Documentation Status
- [ ] `Doc - TODO`
- [ ] `Doc - Done`
- [x] `Doc - No Need`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
