contrueCT commented on code in PR #3040: URL: https://github.com/apache/hugegraph/pull/3040#discussion_r3409900683
########## hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh: ########## @@ -98,6 +99,11 @@ $TRAVIS_DIR/start-server.sh $SERVER_DIR $BACKEND $JACOCO_PORT || (cat $SERVER_DI # run api-test mvn test -pl hugegraph-server/hugegraph-test -am -P api-test,$BACKEND || (cat $SERVER_DIR/logs/hugegraph-server.log && exit 1) +if [ "$RUN_GREMLIN_CONSOLE_SMOKE_TEST" == "true" ]; then + $TRAVIS_DIR/run-gremlin-console-smoke-test.sh "$SERVER_DIR" || \ Review Comment: Thanks, you were right about the invocation issue. The helper was added as a non-executable script, and the original workflow invoked it through bash. When moving the smoke test into run-api-test.sh to keep it inside the live server window, the call accidentally became direct execution. I updated run-api-test.sh to invoke the helper through bash again, kept the smoke test inside the API-test server lifecycle, and adjusted the console script so it works under Gremlin Console's -e evaluation model. The latest Server CI is green on Linux rocksdb and both macOS runners, with the smoke marker emitted after connecting to the live Gremlin Server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
