imbajin commented on code in PR #3040: URL: https://github.com/apache/hugegraph/pull/3040#discussion_r3408611246
########## hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh: ########## @@ -98,6 +99,11 @@ $TRAVIS_DIR/start-server.sh $SERVER_DIR $BACKEND $JACOCO_PORT || (cat $SERVER_DI # run api-test mvn test -pl hugegraph-server/hugegraph-test -am -P api-test,$BACKEND || (cat $SERVER_DIR/logs/hugegraph-server.log && exit 1) +if [ "$RUN_GREMLIN_CONSOLE_SMOKE_TEST" == "true" ]; then + $TRAVIS_DIR/run-gremlin-console-smoke-test.sh "$SERVER_DIR" || \ Review Comment: ‼️ **Make the smoke helper executable or invoke it through bash** Evidence: this line executes `$TRAVIS_DIR/run-gremlin-console-smoke-test.sh` directly, but the new file is checked in as mode `100644` (`git ls-tree HEAD .../run-gremlin-console-smoke-test.sh`) and local `test -x` returns false. The latest `build-server (rocksdb, 11)` job reaches this line after the API tests pass and then fails with `Permission denied`. Impact: every CI path that enables the smoke test fails before validating Gremlin Console. Please either commit the helper with executable mode (`chmod +x`) or call it explicitly with `bash` here and in the macOS path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
