imbajin commented on code in PR #3055:
URL: https://github.com/apache/hugegraph/pull/3055#discussion_r3373393928
##########
.github/workflows/server-ci.yml:
##########
@@ -76,7 +76,15 @@ jobs:
mvn package -Dmaven.test.skip=true -pl
hugegraph-server/hugegraph-dist -am -ntp
VERSION=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
SERVER_DIR=hugegraph-server/apache-hugegraph-server-$VERSION/
+ set +e
$TRAVIS_DIR/test-start-hugegraph.sh $SERVER_DIR
+ EXIT=$?
+ set -e
+ if [ $EXIT -eq 77 ]; then
+ echo "::notice::Startup tests skipped — required tools not
available"
+ exit 0
Review Comment:
‼️ **Report missing-prerequisite startup tests as skipped, not successful**
Evidence: this wrapper turns the test script `77` into `exit 0` after
emitting a notice. I reproduced the script side with a dummy dist and
restricted `PATH`: all three startup scripts return `77` when `lsof` is
unavailable, but the workflow wrapper converts that case to a successful step.
In GitHub Actions, `::notice::` only creates an annotation; the final `exit 0`
still marks the startup-test step as success.
Impact: the PR makes the logs clearer, but the check remains green exactly
like a real passing startup suite. That keeps the original ambiguity for
maintainers who inspect only the check result.
Requested fix: split this into a preflight step that writes `can_run=false`
and a specific `skip_reason` to `$GITHUB_OUTPUT`, then guard the real
startup-test step with `if: steps.<preflight>.outputs.can_run == 'true'`. Add a
separate notice/summary step for the skip path. While doing that, keep the
reason specific so the store `ulimit -n < 1024` case is not reported as missing
tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
