bitflicker64 opened a new pull request, #3055:
URL: https://github.com/apache/hugegraph/pull/3055
## Purpose of the PR
- relates to #3043
- follow-up to #3044, #3047
The three startup test scripts (`test-start-hugegraph.sh`,
`test-start-hugegraph-pd.sh`, `test-start-hugegraph-store.sh`) exit `0` when
required tools (`lsof`, `curl`, `java`) are not found. Exit code `0` is
indistinguishable from a passing test run — CI shows green even though no tests
ran.
## Main Changes
**Test scripts:**
- Change `exit 0` → `exit 77` in all tool-missing skip paths
- Change `exit 0` → `exit 77` in the Store `ulimit -n` skip path
**CI workflows (`server-ci.yml`, `pd-store-ci.yml`):**
- Wrap each test step with `set +e` / exit code capture
- Treat exit `77` as a visible `::notice::` annotation (not a failure)
- All other non-zero exits still fail the step
## Verifying these changes
- [x] Need tests and can be verified as follows:
- Remove `lsof` from the runner path → CI step shows `::notice::...
skipped` instead of silently passing
- Normal run (all tools present) → exit `0`, step passes as before
- Test failure → exit `1`, step fails as before
## Does this PR potentially affect the following parts?
- [ ] Dependencies
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects
- [x] Nope
## Documentation Status
- [x] `Doc - No Need`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]