imbajin commented on code in PR #356: URL: https://github.com/apache/hugegraph-ai/pull/356#discussion_r3367950344
########## hugegraph-llm/src/tests/document/test_vector_index_utils.py: ########## @@ -0,0 +1,288 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from types import SimpleNamespace + +import gradio as gr +import pytest +from pypdf import PdfWriter +from docx import Document Review Comment: ⚠️ **Fix the import order before CI runs Ruff** Evidence: `uv run ruff check hugegraph-llm/src/hugegraph_llm/utils/vector_index_utils.py hugegraph-llm/src/tests/document/test_vector_index_utils.py` reports `I001 Import block is un-sorted or un-formatted` for this file. `ruff format --check` and the PDF pytest target pass, but the lint job will still fail until these imports are sorted. Impact: the PR can remain red even though the PDF behavior tests pass. Please let Ruff organize the import block or swap these two third-party imports. ```suggestion from docx import Document from pypdf import PdfWriter ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
