imbajin commented on code in PR #356:
URL: https://github.com/apache/hugegraph-ai/pull/356#discussion_r3355203922
##########
hugegraph-llm/pyproject.toml:
##########
@@ -53,6 +53,7 @@ dependencies = [
"gradio",
"jieba",
"python-docx",
+ "pypdf",
Review Comment:
⚠️ **Consider constraining the new PDF dependency**
`pypdf` is added to `hugegraph-llm/pyproject.toml`, but it is not added to
the root `tool.uv.constraint-dependencies` block where the repo already
constrains adjacent LLM/runtime dependencies such as `python-docx`, `gradio`,
and `langchain-text-splitters`.
This is not a correctness blocker, but it leaves `uv sync --extra llm
--extra dev` free to resolve different `pypdf` versions over time. Please
consider adding a root constraint, for example `pypdf~=6.12.0`, to keep
dependency resolution reproducible with the rest of the LLM stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]