[ https://issues.apache.org/jira/browse/HIVE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177907#comment-16177907 ]
Hive QA commented on HIVE-17576: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12888631/HIVE-17576.2-branch-2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10612 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[explaindenpendencydiffengs] (batchId=38) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb] (batchId=142) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic] (batchId=139) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[columnstats_part_coltype] (batchId=156) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid] (batchId=158) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=153) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=144) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[merge_negative_5] (batchId=88) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[explaindenpendencydiffengs] (batchId=115) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_ptf] (batchId=125) org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=176) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6962/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6962/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6962/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12888631 - PreCommit-HIVE-Build > Improve progress-reporting in TezProcessor > ------------------------------------------ > > Key: HIVE-17576 > URL: https://issues.apache.org/jira/browse/HIVE-17576 > Project: Hive > Issue Type: Bug > Affects Versions: 2.2.0, 3.0.0, 2.4.0 > Reporter: Mithun Radhakrishnan > Assignee: Mithun Radhakrishnan > Attachments: HIVE-17576.1.patch, HIVE-17576.2-branch-2.patch, > HIVE-17576.2.patch > > > Another one on behalf of [~selinazh] and [~cdrome]. Following the example in > [Apache Tez's > {{MapProcessor}}|https://github.com/apache/tez/blob/247719d7314232f680f028f4e1a19370ffb7b1bb/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/map/MapProcessor.java#L88], > {{TezProcessor}} ought to use {{ProgressHelper}} to report progress for a > Tez task. As per [~kshukla]'s advice, > {quote} > Tez... provides {{getProgress()}} API for {{AbstractLogicalInput(s)}} which > will give the correct progress value for a given Input. The TezProcessor(s) > in Hive should use this to do something similar to what MapProcessor in Tez > does today, which is use/override ProgressHelper to get the input progress > and then set the progress on the processorContext. > ... > The default behavior of the ProgressHelper class sets the processor progress > to be the average of progress values from all inputs. > {quote} > This code is -whacked from- *inspired by* {{MapProcessor}}'s use of > {{ProgressHelper}}. > (For my reference, YHIVE-978.) -- This message was sent by Atlassian JIRA (v6.4.14#64029)