[ https://issues.apache.org/jira/browse/HIVE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176131#comment-16176131 ]
Hive QA commented on HIVE-17576: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12888406/HIVE-17576.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 11051 tests executed *Failed tests:* {noformat} TestAccumuloCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=231) TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=231) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=156) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=170) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=235) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=235) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6938/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6938/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6938/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12888406 - PreCommit-HIVE-Build > Improve progress-reporting in TezProcessor > ------------------------------------------ > > Key: HIVE-17576 > URL: https://issues.apache.org/jira/browse/HIVE-17576 > Project: Hive > Issue Type: Bug > Affects Versions: 2.2.0, 3.0.0, 2.4.0 > Reporter: Mithun Radhakrishnan > Assignee: Chris Drome > Attachments: HIVE-17576.1.patch > > > Another one on behalf of [~selinazh] and [~cdrome]. Following the example in > [Apache Tez's > {{MapProcessor}}|https://github.com/apache/tez/blob/247719d7314232f680f028f4e1a19370ffb7b1bb/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/map/MapProcessor.java#L88], > {{TezProcessor}} ought to use {{ProgressHelper}} to report progress for a > Tez task. As per [~kshukla]'s advice, > {quote} > Tez... provides {{getProgress()}} API for {{AbstractLogicalInput(s)}} which > will give the correct progress value for a given Input. The TezProcessor(s) > in Hive should use this to do something similar to what MapProcessor in Tez > does today, which is use/override ProgressHelper to get the input progress > and then set the progress on the processorContext. > ... > The default behavior of the ProgressHelper class sets the processor progress > to be the average of progress values from all inputs. > {quote} > This code is -whacked from- *inspired by* {{MapProcessor}}'s use of > {{ProgressHelper}}. > (For my reference, YHIVE-978.) -- This message was sent by Atlassian JIRA (v6.4.14#64029)