[ 
https://issues.apache.org/jira/browse/HIVE-17022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075209#comment-16075209
 ] 

Naveen Gangam commented on HIVE-17022:
--------------------------------------

I only looked at the {{public}} access for the lock() but did not realize it 
wasnt being called from outside. Makes sense to make it private in this case.
Thanks for the changes. The patch looks good to me. +1 pending tests

> Add mode in lock debug statements
> ---------------------------------
>
>                 Key: HIVE-17022
>                 URL: https://issues.apache.org/jira/browse/HIVE-17022
>             Project: Hive
>          Issue Type: Improvement
>          Components: Locking
>            Reporter: Mohit Sabharwal
>            Assignee: Mohit Sabharwal
>            Priority: Trivial
>         Attachments: HIVE-17022.1.patch, HIVE-17022.patch
>
>
> Currently, lock debug statements print IMPLICIT/EXPLICIT as lock mode,
> whereas SHARED/EXCLUSIVE/SEMI_SHARED are more useful
> when debugging.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to