[
https://issues.apache.org/jira/browse/HIVE-17022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075199#comment-16075199
]
Mohit Sabharwal commented on HIVE-17022:
----------------------------------------
Thanks.
Note that Logger is from slf4j not log4j, so there is no extra cost of string
formatting.
But its probably better to add the conditional for readability. The other lock
is really
just a helper, so making it private. Printed sorted locks is a great idea.
Updating patch.
> Add mode in lock debug statements
> ---------------------------------
>
> Key: HIVE-17022
> URL: https://issues.apache.org/jira/browse/HIVE-17022
> Project: Hive
> Issue Type: Improvement
> Components: Locking
> Reporter: Mohit Sabharwal
> Assignee: Mohit Sabharwal
> Priority: Trivial
> Attachments: HIVE-17022.1.patch, HIVE-17022.patch
>
>
> Currently, lock debug statements print IMPLICIT/EXPLICIT as lock mode,
> whereas SHARED/EXCLUSIVE/SEMI_SHARED are more useful
> when debugging.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
