[
https://issues.apache.org/jira/browse/HIVE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030273#comment-16030273
]
Sergio Peña commented on HIVE-16771:
------------------------------------
The patch looks good. It might need more refactoring, but it looks a bigger
task.
+1
> Schematool should use MetastoreSchemaInfo to get the metastore schema version
> from database
> -------------------------------------------------------------------------------------------
>
> Key: HIVE-16771
> URL: https://issues.apache.org/jira/browse/HIVE-16771
> Project: Hive
> Issue Type: Improvement
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Minor
> Attachments: HIVE-16771.01.patch, HIVE-16771.02.patch,
> HIVE-16771.03.patch
>
>
> HIVE-16723 gives the ability to have a custom MetastoreSchemaInfo
> implementation to manage schema upgrades and initialization if needed. In
> order to make HiveSchemaTool completely agnostic it should depend on
> IMetastoreSchemaInfo implementation which is configured to get the metastore
> schema version information from the database. It should also not assume the
> scripts directory and hardcode it itself. It would rather ask
> MetastoreSchemaInfo class to get the metastore scripts directory.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
