[
https://issues.apache.org/jira/browse/HIVE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026487#comment-16026487
]
Naveen Gangam commented on HIVE-16771:
--------------------------------------
I think it makes sense to have the getMetaStoreSchemaVersion() API on the
{{IMetaStoreSchemaInfo}}.
1) However, it seems a bit odd to have it take a boolean to determine if the
query needs quotes or not. Can the implementation detect it without a whole lot
of code duplication? The impl should be able to determine the DBTYPE just as
easily.
2) The connection and the statement are not closed. This is will certainly
cause a memory leak and a potentially a connection leak to the DB.
3) Same with the need to have an active SQL connection passed in. But then is
there a better means to do this?
4) Ideally, the HMS schema version should only be fetched from DB just once.
This implementation fetches it every time. Are there scenarios where the value
would be changed after initialization that makes it necessary every time?
Thanks
> Schematool should use MetastoreSchemaInfo to get the metastore schema version
> from database
> -------------------------------------------------------------------------------------------
>
> Key: HIVE-16771
> URL: https://issues.apache.org/jira/browse/HIVE-16771
> Project: Hive
> Issue Type: Improvement
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Minor
> Attachments: HIVE-16771.01.patch
>
>
> HIVE-16723 gives the ability to have a custom MetastoreSchemaInfo
> implementation to manage schema upgrades and initialization if needed. In
> order to make HiveSchemaTool completely agnostic it should depend on
> IMetastoreSchemaInfo implementation which is configured to get the metastore
> schema version information from the database. It should also not assume the
> scripts directory and hardcode it itself. It would rather ask
> MetastoreSchemaInfo class to get the metastore scripts directory.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
