[ 
https://issues.apache.org/jira/browse/HIVE-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305073#comment-15305073
 ] 

Siddharth Seth commented on HIVE-13490:
---------------------------------------

This looks good to me, at least to enable better itests imports into the IDE. 
The ptest changes are not mandatory - and a separate jira can be used to make 
additional changes for ptest to potentially use this profile.

Tried this on IntelliJ and Eclipse - worked fine. Also local mvn installs with 
and without the profile.

Waiting for the jenkins run to commit. [~spena], [~ashutoshc] - do you see any 
concerns with the patch ?

Thanks [~kgyrtkirk]. The docs at 
https://cwiki.apache.org/confluence/display/Hive/HowToContribute will also need 
to be updated. Is that something you can take up once the patch is committed ?

> Change itests to be part of the main Hive build
> -----------------------------------------------
>
>                 Key: HIVE-13490
>                 URL: https://issues.apache.org/jira/browse/HIVE-13490
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-13490.01.patch, HIVE-13490.02.patch, 
> HIVE-13490.03.patch
>
>
> Instead of having to build Hive, and then itests separately.
> With IntelliJ, this ends up being loaded as two separate dependencies, and 
> there's a lot of hops involved to make changes.
> Does anyone know why these have been kept separate ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to