[ 
https://issues.apache.org/jira/browse/HIVE-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120896#comment-15120896
 ] 

Ashutosh Chauhan commented on HIVE-12893:
-----------------------------------------

Doing conversion to static partition spec for all constants in follow-up sounds 
good.

But, patch & description is still not geling will for me. Title & description 
of jira is suggesting a presence of bug when few (and not all) columns are 
constant.  However, If I read the patch right, it is basically an optimization 
of disabling SPDO off if all columns are determined to be the constant. Issue 
described in title/description seems to be non-existent. Can you explain it and 
if necessary, update title/description of jira.

Patch itself however looks good. +1

> Sorted dynamic partition does not work if subset of partition columns are 
> constant folded
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-12893
>                 URL: https://issues.apache.org/jira/browse/HIVE-12893
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer
>    Affects Versions: 1.3.0, 2.0.0
>            Reporter: Yi Zhang
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-12893.1.patch, HIVE-12893.2.patch
>
>
> If all partition columns are constant folded then sorted dynamic partitioning 
> should not be used as it is similar to static partitioning. But if only 
> subset of partition columns are constant folded sorted dynamic partition 
> optimization will be helpful. Currently, this optimization is disabled if 
> atleast one partition column constant folded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to