[ https://issues.apache.org/jira/browse/HIVE-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109622#comment-15109622 ]
Ashutosh Chauhan commented on HIVE-12893: ----------------------------------------- When all columns are constant folded, we disable SDPO, but do we also convert this to static partition insert code path? Perhaps here: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java#L1220 Didn't get the intended behavior for case of subset getting folded. In the existing test case it seems like ReduceSinkDedup wasn't kicking in. Was that the primary bug being fixed here? > Sorted dynamic partition does not work if subset of partition columns are > constant folded > ----------------------------------------------------------------------------------------- > > Key: HIVE-12893 > URL: https://issues.apache.org/jira/browse/HIVE-12893 > Project: Hive > Issue Type: Bug > Components: Logical Optimizer > Affects Versions: 1.3.0, 2.0.0 > Reporter: Yi Zhang > Assignee: Prasanth Jayachandran > Attachments: HIVE-12893.1.patch > > > If all partition columns are constant folded then sorted dynamic partitioning > should not be used as it is similar to static partitioning. But if only > subset of partition columns are constant folded sorted dynamic partition > optimization will be helpful. Currently, this optimization is disabled if > atleast one partition column constant folded. -- This message was sent by Atlassian JIRA (v6.3.4#6332)