[
https://issues.apache.org/jira/browse/HIVE-27158?focusedWorklogId=856662&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856662
]
ASF GitHub Bot logged work on HIVE-27158:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/23 08:09
Start Date: 13/Apr/23 08:09
Worklog Time Spent: 10m
Work Description: InvisibleProgrammer commented on code in PR #4131:
URL: https://github.com/apache/hive/pull/4131#discussion_r1165162320
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -318,7 +335,7 @@ public Map<String, String> getBasicStatistics(Partish
partish) {
org.apache.hadoop.hive.ql.metadata.Table hmsTable = partish.getTable();
// For write queries where rows got modified, don't fetch from cache as
values could have changed.
Table table = getTable(hmsTable);
- String statsSource = HiveConf.getVar(conf,
HiveConf.ConfVars.HIVE_USE_STATS_FROM).toLowerCase();
+ String statsSource = HiveConf.getVar(conf,
HiveConf.ConfVars.HIVE_ICEBERG_STATS_SOURCE).toLowerCase();
Review Comment:
I wonder, what that change exactly changes? As I see, it gets the exact same
value now as before the change:
```java
HIVE_USE_STATS_FROM("hive.use.stats.from","iceberg","Use stats from
iceberg table snapshot for query " +
"planning. This has three values metastore, puffin and iceberg"),
```
Issue Time Tracking
-------------------
Worklog Id: (was: 856662)
Time Spent: 9h 50m (was: 9h 40m)
> Store hive columns stats in puffin files for iceberg tables
> -----------------------------------------------------------
>
> Key: HIVE-27158
> URL: https://issues.apache.org/jira/browse/HIVE-27158
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
