[ https://issues.apache.org/jira/browse/HIVE-27158?focusedWorklogId=856659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856659 ]
ASF GitHub Bot logged work on HIVE-27158: ----------------------------------------- Author: ASF GitHub Bot Created on: 13/Apr/23 08:01 Start Date: 13/Apr/23 08:01 Worklog Time Spent: 10m Work Description: InvisibleProgrammer commented on code in PR #4131: URL: https://github.com/apache/hive/pull/4131#discussion_r1165152436 ########## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ########## @@ -2205,9 +2205,8 @@ public static enum ConfVars { "padding tolerance config (hive.exec.orc.block.padding.tolerance)."), HIVE_ORC_CODEC_POOL("hive.use.orc.codec.pool", false, "Whether to use codec pool in ORC. Disable if there are bugs with codec reuse."), - HIVE_USE_STATS_FROM("hive.use.stats.from","iceberg","Use stats from iceberg table snapshot for query " + - "planning. This has three values metastore, puffin and iceberg"), - + HIVE_ICEBERG_STATS_SOURCE("hive.iceberg.stats.source","iceberg","Use stats from iceberg " + Review Comment: Is it worth adding a PatternSet as it is used for `HIVESTATSDBCLASS("hive.stats.dbclass", "fs", new PatternSet("custom", "fs"),`? In that way, it would be easy to understand what are the accepted values, for the first look at the code. Also, I wonder, if is there any other way to do similar stuff with settings? Issue Time Tracking ------------------- Worklog Id: (was: 856659) Time Spent: 9h 20m (was: 9h 10m) > Store hive columns stats in puffin files for iceberg tables > ----------------------------------------------------------- > > Key: HIVE-27158 > URL: https://issues.apache.org/jira/browse/HIVE-27158 > Project: Hive > Issue Type: Improvement > Reporter: Simhadri Govindappa > Assignee: Simhadri Govindappa > Priority: Major > Labels: pull-request-available > Time Spent: 9h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)