[ 
https://issues.apache.org/jira/browse/HIVE-26832?focusedWorklogId=836601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836601
 ]

ASF GitHub Bot logged work on HIVE-26832:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jan/23 12:32
            Start Date: 03/Jan/23 12:32
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3849:
URL: https://github.com/apache/hive/pull/3849#discussion_r1060542498


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/show/ShowPartitionsOperation.java:
##########
@@ -116,4 +120,22 @@ private List<String> getPartitionNames(Table tbl) throws 
HiveException {
         desc.getOrder(), desc.getLimit());
     return partNames;
   }
+
+  private boolean isPartitionedIcebergTable(Table tbl) {
+    String t = tbl.getParameters().get("table_type");
+    return t != null && t.equalsIgnoreCase("ICEBERG") &&
+        (tbl.getStorageHandler().getPartitionTransformSpec(tbl).size() > 0);
+  }
+
+  private List<String> getIcebergParts(Table tbl) {

Review Comment:
   same here, can we incorporate this into getPartCols() ?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 836601)
    Time Spent: 1h 50m  (was: 1h 40m)

> Implement SHOW PARTITIONS for Iceberg
> -------------------------------------
>
>                 Key: HIVE-26832
>                 URL: https://issues.apache.org/jira/browse/HIVE-26832
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Simhadri Govindappa
>            Assignee: Simhadri Govindappa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Show partition command for iceberg tables should reflect the partition info 
> from theĀ iceberg.partition metadata table based on the default-spec-id .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to