[
https://issues.apache.org/jira/browse/HIVE-26832?focusedWorklogId=836600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836600
]
ASF GitHub Bot logged work on HIVE-26832:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/23 12:27
Start Date: 03/Jan/23 12:27
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3849:
URL: https://github.com/apache/hive/pull/3849#discussion_r1060538350
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/show/ShowPartitionsOperation.java:
##########
@@ -54,12 +54,16 @@ public ShowPartitionsOperation(DDLOperationContext context,
ShowPartitionsDesc d
@Override
public int execute() throws HiveException {
Table tbl = context.getDb().getTable(desc.getTabName());
- if (!tbl.isPartitioned()) {
- throw new HiveException(ErrorMsg.TABLE_NOT_PARTITIONED,
desc.getTabName());
+ boolean isPartitionedIcebergTable = isPartitionedIcebergTable(tbl);
+ if (!(tbl.isPartitioned() || isPartitionedIcebergTable)) {
Review Comment:
Why don't we extend tbl.isPartitioned() with iceberg support instead of
extra checks?
for checking if the table is Iceberg, we could create a helper method in
HiveTableOperations next to validateTableIsIceberg or maybe directly in Table
(i.e. tbl.isIcebergTable())
Issue Time Tracking
-------------------
Worklog Id: (was: 836600)
Time Spent: 1h 40m (was: 1.5h)
> Implement SHOW PARTITIONS for Iceberg
> -------------------------------------
>
> Key: HIVE-26832
> URL: https://issues.apache.org/jira/browse/HIVE-26832
> Project: Hive
> Issue Type: New Feature
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Show partition command for iceberg tables should reflect the partition info
> from the iceberg.partition metadata table based on the default-spec-id .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
