[
https://issues.apache.org/jira/browse/HIVE-26221?focusedWorklogId=832758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-832758
]
ASF GitHub Bot logged work on HIVE-26221:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/22 14:25
Start Date: 12/Dec/22 14:25
Worklog Time Spent: 10m
Work Description: asolimando commented on code in PR #3137:
URL: https://github.com/apache/hive/pull/3137#discussion_r1045890680
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java:
##########
@@ -1004,41 +1045,51 @@ private long evaluateComparator(Statistics stats,
AnnotateStatsProcCtx aspCtx, E
closedBound = isClosedBound(udf);
} else {
// default
- return numRows / 3;
+ return currNumRows / 3;
}
ColStatistics cs =
stats.getColumnStatisticsFromColName(columnDesc.getColumn());
+ String colTypeLowerCase = columnDesc.getTypeString().toLowerCase();
+
+ if (FilterSelectivityEstimator.isHistogramAvailable(cs)) {
+ try {
+ return evaluateComparatorWithHistogram(
+ cs, currNumRows, colTypeLowerCase, boundValue, upperBound,
closedBound);
+ } catch (SketchesArgumentException e) {
+ LOG.info("Sketch-based statistics estimation failed, falling back to
regular estimation", e);
Review Comment:
That specific family of methods from _slf4j_ with an extra `Throwable`
parameter already take care of nicely formatting the exception, no separator is
needed, you can check here for some examples of how the stacktrace will be
displayed after the debug message:
https://www.baeldung.com/slf4j-log-exceptions
Issue Time Tracking
-------------------
Worklog Id: (was: 832758)
Time Spent: 9h 40m (was: 9.5h)
> Add histogram-based column statistics
> -------------------------------------
>
> Key: HIVE-26221
> URL: https://issues.apache.org/jira/browse/HIVE-26221
> Project: Hive
> Issue Type: Improvement
> Components: CBO, Metastore, Statistics
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> Hive does not support histogram statistics, which are particularly useful for
> skewed data (which is very common in practice) and range predicates.
> Hive's current selectivity estimation for range predicates is based on a
> hard-coded value of 1/3 (see
> [FilterSelectivityEstimator.java#L138-L144|https://github.com/apache/hive/blob/56c336268ea8c281d23c22d89271af37cb7e2572/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/FilterSelectivityEstimator.java#L138-L144]).])
> The current proposal aims at integrating histogram as an additional column
> statistics, stored into the Hive metastore at the table (or partition) level.
> The main requirements for histogram integration are the following:
> * efficiency: the approach must scale and support billions of rows
> * merge-ability: partition-level histograms have to be merged to form
> table-level histograms
> * explicit and configurable trade-off between memory footprint and accuracy
> Hive already integrates [KLL data
> sketches|https://datasketches.apache.org/docs/KLL/KLLSketch.html] UDAF.
> Datasketches are small, stateful programs that process massive data-streams
> and can provide approximate answers, with mathematical guarantees, to
> computationally difficult queries orders-of-magnitude faster than
> traditional, exact methods.
> We propose to use KLL, and more specifically the cumulative distribution
> function (CDF), as the underlying data structure for our histogram statistics.
> The current proposal targets numeric data types (float, integer and numeric
> families) and temporal data types (date and timestamp).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
