[ 
https://issues.apache.org/jira/browse/HIVE-26569?focusedWorklogId=831502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831502
 ]

ASF GitHub Bot logged work on HIVE-26569:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Dec/22 17:11
            Start Date: 06/Dec/22 17:11
    Worklog Time Spent: 10m 
      Work Description: abstractdog commented on code in PR #3626:
URL: https://github.com/apache/hive/pull/3626#discussion_r1041242965


##########
llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenSelector.java:
##########
@@ -30,6 +30,9 @@
 public class LlapTokenSelector implements TokenSelector<LlapTokenIdentifier> {
   private static final Logger LOG = 
LoggerFactory.getLogger(LlapTokenSelector.class);
 
+  public LlapTokenSelector() {
+  }
+

Review Comment:
   maybe leftover, I remember I needed it for making TOKEN auth work 
(reflection stuff in hadoop maybe), but now I cannot find any proof in hadoop 
code that it's needed LOL
   I'm testing without the constructor, if it works, I'll remove, if it's 
needed, I'll put code comment





Issue Time Tracking
-------------------

    Worklog Id:     (was: 831502)
    Time Spent: 3h 50m  (was: 3h 40m)

> Support renewal and recreation of LLAP_TOKENs
> ---------------------------------------------
>
>                 Key: HIVE-26569
>                 URL: https://issues.apache.org/jira/browse/HIVE-26569
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to