[ 
https://issues.apache.org/jira/browse/HIVE-26569?focusedWorklogId=831496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831496
 ]

ASF GitHub Bot logged work on HIVE-26569:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Dec/22 16:59
            Start Date: 06/Dec/22 16:59
    Worklog Time Spent: 10m 
      Work Description: abstractdog commented on code in PR #3626:
URL: https://github.com/apache/hive/pull/3626#discussion_r1041230117


##########
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java:
##########
@@ -190,31 +173,46 @@ public LlapTaskCommunicator(
     }
   }
 
+  @SuppressWarnings("unchecked")
+  private Token<LlapTokenIdentifier> getLlapToken() {
+    Token<LlapTokenIdentifier> token = null;
+    Credentials credentials = getContext().getAMCredentials();
+    if (credentials != null) {
+      token = (Token<LlapTokenIdentifier>) 
credentials.getToken(LlapTokenIdentifier.KIND_NAME);
+    }
+    Preconditions.checkState((token != null) == 
UserGroupInformation.isSecurityEnabled());
+    LOG.info("Task communicator with a token {}", token);

Review Comment:
   agree, putting a comment:
   ```
   // supposed to have a token only if security is enabled (any mismatch here 
implies a configuration problem)
   ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 831496)
    Time Spent: 3h  (was: 2h 50m)

> Support renewal and recreation of LLAP_TOKENs
> ---------------------------------------------
>
>                 Key: HIVE-26569
>                 URL: https://issues.apache.org/jira/browse/HIVE-26569
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to