[ https://issues.apache.org/jira/browse/HIVE-26770?focusedWorklogId=829665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829665 ]
ASF GitHub Bot logged work on HIVE-26770: ----------------------------------------- Author: ASF GitHub Bot Created on: 29/Nov/22 11:03 Start Date: 29/Nov/22 11:03 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3803: URL: https://github.com/apache/hive/pull/3803#discussion_r1034607698 ########## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorThread.java: ########## @@ -61,6 +61,13 @@ public abstract class CompactorThread extends Thread implements Configurable { protected String hostName; protected String runtimeVersion; + //Time threshold for compactor thread log + //In milliseconds: + protected Integer MAX_WARN_LOG_TIME = 1200000; //20 min Review Comment: ok, let's keep it hardcoded for now Issue Time Tracking ------------------- Worklog Id: (was: 829665) Time Spent: 3h 20m (was: 3h 10m) > Make "end of loop" compaction logs appear more selectively > ---------------------------------------------------------- > > Key: HIVE-26770 > URL: https://issues.apache.org/jira/browse/HIVE-26770 > Project: Hive > Issue Type: Improvement > Reporter: Akshat Mathur > Assignee: Akshat Mathur > Priority: Major > Labels: pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > Currently Initiator, Worker, and Cleaner threads log something like "finished > one loop" on INFO level. > This is useful to figure out if one of these threads is taking too long to > finish a loop, but expensive in general. > > Suggested Time: 20mins > Logging this should be changed in the following way > # If loop finished within a predefined amount of time, level should be DEBUG > and message should look like: *Initiator loop took \{ellapsedTime} seconds to > finish.* > # If loop ran longer than this predefined amount, level should be WARN and > message should look like: *Possible Initiator slowdown, loop took > \{ellapsedTime} seconds to finish.* -- This message was sent by Atlassian Jira (v8.20.10#820010)