[
https://issues.apache.org/jira/browse/HIVE-26770?focusedWorklogId=829564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829564
]
ASF GitHub Bot logged work on HIVE-26770:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/22 07:39
Start Date: 29/Nov/22 07:39
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3803:
URL: https://github.com/apache/hive/pull/3803#discussion_r1034392246
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -123,8 +126,12 @@ public void run() {
} catch (InterruptedException e) {
}
}
- LOG.info("Worker thread finished one loop.");
+ Instant loopEndTime = Instant.now();
+ Duration timeElapsed = Duration.between(loopStartTime, loopEndTime);
Review Comment:
why not simply `long elapsedTime = System.currentTimeMillis() - startedAt;`
Issue Time Tracking
-------------------
Worklog Id: (was: 829564)
Time Spent: 2.5h (was: 2h 20m)
> Make "end of loop" compaction logs appear more selectively
> ----------------------------------------------------------
>
> Key: HIVE-26770
> URL: https://issues.apache.org/jira/browse/HIVE-26770
> Project: Hive
> Issue Type: Improvement
> Reporter: Akshat Mathur
> Assignee: Akshat Mathur
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently Initiator, Worker, and Cleaner threads log something like "finished
> one loop" on INFO level.
> This is useful to figure out if one of these threads is taking too long to
> finish a loop, but expensive in general.
>
> Suggested Time: 20mins
> Logging this should be changed in the following way
> # If loop finished within a predefined amount of time, level should be DEBUG
> and message should look like: *Initiator loop took \{ellapsedTime} seconds to
> finish.*
> # If loop ran longer than this predefined amount, level should be WARN and
> message should look like: *Possible Initiator slowdown, loop took
> \{ellapsedTime} seconds to finish.*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
