[
https://issues.apache.org/jira/browse/HIVE-21599?focusedWorklogId=824885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824885
]
ASF GitHub Bot logged work on HIVE-21599:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/22 10:43
Start Date: 10/Nov/22 10:43
Worklog Time Spent: 10m
Work Description: asolimando commented on code in PR #3742:
URL: https://github.com/apache/hive/pull/3742#discussion_r1018937940
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ParquetRecordReaderBase.java:
##########
@@ -209,6 +214,22 @@ public FilterCompat.Filter setFilter(final JobConf conf,
MessageType schema) {
}
}
+ private MessageType getSchemaWithoutPartitionColumns(JobConf conf,
MessageType schema) {
+ String partCols = conf.get(IOConstants.PARTITION_COLUMNS);
+ if (partCols != null && partCols.length() > 0) {
Review Comment:
```suggestion
if (partCols != null && !partCols.isEmpty()) {
```
Nit: maybe using isEmpty here can help?
Issue Time Tracking
-------------------
Worklog Id: (was: 824885)
Time Spent: 2h 10m (was: 2h)
> Remove predicate on partition columns from Table Scan operator
> --------------------------------------------------------------
>
> Key: HIVE-21599
> URL: https://issues.apache.org/jira/browse/HIVE-21599
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
> Reporter: Vineet Garg
> Assignee: Vineet Garg
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21599.1.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Filter predicates are pushed to Table Scan (to be pushed to and used by
> storage handler/input format). Such predicates could consist of partition
> columns which are of no use to storage handler or input formats. Therefore
> it should be removed from TS filter expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
