[
https://issues.apache.org/jira/browse/HIVE-21599?focusedWorklogId=824882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824882
]
ASF GitHub Bot logged work on HIVE-21599:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/22 10:40
Start Date: 10/Nov/22 10:40
Worklog Time Spent: 10m
Work Description: asolimando commented on code in PR #3742:
URL: https://github.com/apache/hive/pull/3742#discussion_r1018934359
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##########
@@ -4272,6 +4273,21 @@ public static void addTableSchemaToConf(Configuration
conf,
LOG.info("schema.evolution.columns and schema.evolution.columns.types
not available");
}
}
+ public static void setPartitionColumnsToConf(Configuration conf,
TableScanOperator tableScanOp) {
+ TableScanDesc scanDesc = tableScanOp.getConf();
+ if (scanDesc != null && scanDesc.getTableMetadata() != null) {
+ List<String> partitionColsList =
scanDesc.getTableMetadata().getPartColNames();
+ if (!partitionColsList.isEmpty()) {
+ conf.set(IOConstants.PARTITION_COLUMNS, String.join(",",
partitionColsList));
+ }
+ } else {
+ LOG.info(IOConstants.PARTITION_COLUMNS + " not available");
+ }
+ }
+
+ public static void unsetPartitionColumnsInConf(Configuration conf) {
Review Comment:
Public methods should have javadoc added (the same comment applies to the
other public methods as well).
Issue Time Tracking
-------------------
Worklog Id: (was: 824882)
Time Spent: 2h (was: 1h 50m)
> Remove predicate on partition columns from Table Scan operator
> --------------------------------------------------------------
>
> Key: HIVE-21599
> URL: https://issues.apache.org/jira/browse/HIVE-21599
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
> Reporter: Vineet Garg
> Assignee: Vineet Garg
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21599.1.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Filter predicates are pushed to Table Scan (to be pushed to and used by
> storage handler/input format). Such predicates could consist of partition
> columns which are of no use to storage handler or input formats. Therefore
> it should be removed from TS filter expression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
