[
https://issues.apache.org/jira/browse/HIVE-13353?focusedWorklogId=815087&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815087
]
ASF GitHub Bot logged work on HIVE-13353:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/22 03:54
Start Date: 10/Oct/22 03:54
Worklog Time Spent: 10m
Work Description: rkirtir commented on code in PR #3608:
URL: https://github.com/apache/hive/pull/3608#discussion_r990898831
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -3970,6 +3960,78 @@ public ShowCompactResponse
showCompact(ShowCompactRequest rqst) throws MetaExcep
}
}
+ private List<String> getShowCompactionQueryParamList(ShowCompactRequest
request) throws MetaException {
+ String dbName = request.getDbname();
+ String tableName = request.getTablename();
+ String partName = request.getPartitionname();
+ CompactionType type = request.getType();
+ String state = request.getState();
+ String poolName = request.getPoolName();
+ List<String> params = new ArrayList<>();
+ if (dbName != null && !dbName.isEmpty()) {
+ params.add(dbName);
+ }
+ if (tableName != null && !tableName.isEmpty()) {
+ params.add(tableName);
+ }
+ if (partName != null && !partName.isEmpty()) {
+ params.add(partName);
+ }
+ if (state != null && !state.isEmpty()) {
+ params.add(state);
+ }
+ if (type != null) {
+ params.add(thriftCompactionType2DbType(type).toString());
+ }
+ if (org.apache.commons.lang3.StringUtils.isNotBlank(poolName)) {
+ params.add(poolName);
+ }
+ return params;
+ }
+
+ private String getFilterClause(ShowCompactRequest request) {
+ StringBuilder filter = new StringBuilder();
+ String dbName = request.getDbname();
+ String tableName = request.getTablename();
+ String partName = request.getPartitionname();
+ CompactionType type = request.getType();
+ String state = request.getState();
+ String poolName = request.getPoolName();
+ if (dbName != null && !dbName.isEmpty()) {
Review Comment:
Agree. Addressing the same
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5875,6 +5802,15 @@ public ShowCompactResponse showCompactions(String
poolName) throws HiveException
}
}
+ public ShowCompactResponse showCompactions(ShowCompactRequest request)
throws HiveException {
Review Comment:
Agree. Addressing the same
Issue Time Tracking
-------------------
Worklog Id: (was: 815087)
Time Spent: 1h 50m (was: 1h 40m)
> SHOW COMPACTIONS should support filtering options
> -------------------------------------------------
>
> Key: HIVE-13353
> URL: https://issues.apache.org/jira/browse/HIVE-13353
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 1.3.0, 2.0.0
> Reporter: Eugene Koifman
> Assignee: KIRTI RUGE
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-13353.01.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Since we now have historical information in SHOW COMPACTIONS the output can
> easily become unwieldy. (e.g. 1000 partitions with 3 lines of history each)
> this is a significant usability issue
> Need to add ability to filter by db/table/partition
> Perhaps would also be useful to filter by status
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
