[
https://issues.apache.org/jira/browse/HIVE-13353?focusedWorklogId=815086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815086
]
ASF GitHub Bot logged work on HIVE-13353:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/22 03:53
Start Date: 10/Oct/22 03:53
Worklog Time Spent: 10m
Work Description: rkirtir commented on code in PR #3608:
URL: https://github.com/apache/hive/pull/3608#discussion_r990898791
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -3970,6 +3960,78 @@ public ShowCompactResponse
showCompact(ShowCompactRequest rqst) throws MetaExcep
}
}
+ private List<String> getShowCompactionQueryParamList(ShowCompactRequest
request) throws MetaException {
+ String dbName = request.getDbname();
+ String tableName = request.getTablename();
+ String partName = request.getPartitionname();
+ CompactionType type = request.getType();
+ String state = request.getState();
+ String poolName = request.getPoolName();
+ List<String> params = new ArrayList<>();
+ if (dbName != null && !dbName.isEmpty()) {
+ params.add(dbName);
+ }
+ if (tableName != null && !tableName.isEmpty()) {
Review Comment:
Agree. Addressing the same
Issue Time Tracking
-------------------
Worklog Id: (was: 815086)
Time Spent: 1h 40m (was: 1.5h)
> SHOW COMPACTIONS should support filtering options
> -------------------------------------------------
>
> Key: HIVE-13353
> URL: https://issues.apache.org/jira/browse/HIVE-13353
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 1.3.0, 2.0.0
> Reporter: Eugene Koifman
> Assignee: KIRTI RUGE
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-13353.01.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Since we now have historical information in SHOW COMPACTIONS the output can
> easily become unwieldy. (e.g. 1000 partitions with 3 lines of history each)
> this is a significant usability issue
> Need to add ability to filter by db/table/partition
> Perhaps would also be useful to filter by status
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
