[
https://issues.apache.org/jira/browse/HIVE-26529?focusedWorklogId=813311&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813311
]
ASF GitHub Bot logged work on HIVE-26529:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/22 11:45
Start Date: 29/Sep/22 11:45
Worklog Time Spent: 10m
Work Description: szlta commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r983438232
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -125,6 +125,7 @@ public class HiveIcebergMetaHook implements HiveMetaHook {
private static final List<org.apache.commons.lang3.tuple.Pair<Integer,
byte[]>> EMPTY_FILTER =
Lists.newArrayList(org.apache.commons.lang3.tuple.Pair.of(1, new
byte[0]));
static final String MIGRATED_TO_ICEBERG = "MIGRATED_TO_ICEBERG";
+ static final String ORC_FILES_ONLY = "orc.files.only";
Review Comment:
This is probably ends being an Iceberg-Hive integration logic only, and thus
perhaps we should prepend this with "iceberg" so it's `iceberg.orc.files.only`
or something similar.
Issue Time Tracking
-------------------
Worklog Id: (was: 813311)
Time Spent: 4.5h (was: 4h 20m)
> Fix VectorizedSupport support for DECIMAL_64 in HiveIcebergInputFormat
> -----------------------------------------------------------------------
>
> Key: HIVE-26529
> URL: https://issues.apache.org/jira/browse/HIVE-26529
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Rajesh Balamohan
> Assignee: Ayush Saxena
> Priority: Major
> Labels: perfomance, pull-request-available
> Attachments: iceberg_table_with_HiveDecimal.png,
> regular_tables_with_decimal64.png
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> For supporting vectored reads in parquet, DECIMAL_64 support in ORC has been
> disabled in HiveIcebergInputFormat. This causes regressions in queries.
> [https://github.com/apache/hive/blob/master/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java#L182]
> It will be good to restore DECIMAL_64 support in iceberg input format.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
