[
https://issues.apache.org/jira/browse/HIVE-26529?focusedWorklogId=812382&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-812382
]
ASF GitHub Bot logged work on HIVE-26529:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/22 08:09
Start Date: 27/Sep/22 08:09
Worklog Time Spent: 10m
Work Description: szlta commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r980905190
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedInputFormatInterface.java:
##########
@@ -18,11 +18,15 @@
package org.apache.hadoop.hive.ql.exec.vector;
+import org.apache.hadoop.hive.conf.HiveConf;
+
+import java.util.Properties;
+
/**
* Marker interface to indicate a given input format supports
* vectorization input.
*/
public interface VectorizedInputFormatInterface {
- VectorizedSupport.Support[] getSupportedFeatures();
+ VectorizedSupport.Support[] getSupportedFeatures(HiveConf hiveConf,
Properties properties);
Review Comment:
To reduce the scope of the required refactoring. We could add this as a new
method while keeping the old one too.
```
VectorizedSupport.Support[] getSupportedFeatures();
+ default VectorizedSupport.Support[] getSupportedFeatures(HiveConf
hiveConf, Properties properties) {
+ return getSupportedFeatures();
+ }
```
And then in HiveIcebergInputFormat we could have something like:
```
+ public VectorizedSupport.Support[] getSupportedFeatures() {
+ throw new UnsupportedOperationException("This overload of
getSupportedFeatures should never be called");
+ }
+ public VectorizedSupport.Support[] getSupportedFeatures(HiveConf hiveConf,
Properties properties) {
+ //do the logic you have implemented
+ }
```
```
Issue Time Tracking
-------------------
Worklog Id: (was: 812382)
Time Spent: 3h 50m (was: 3h 40m)
> Fix VectorizedSupport support for DECIMAL_64 in HiveIcebergInputFormat
> -----------------------------------------------------------------------
>
> Key: HIVE-26529
> URL: https://issues.apache.org/jira/browse/HIVE-26529
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Rajesh Balamohan
> Assignee: Ayush Saxena
> Priority: Major
> Labels: perfomance, pull-request-available
> Attachments: iceberg_table_with_HiveDecimal.png,
> regular_tables_with_decimal64.png
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> For supporting vectored reads in parquet, DECIMAL_64 support in ORC has been
> disabled in HiveIcebergInputFormat. This causes regressions in queries.
> [https://github.com/apache/hive/blob/master/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java#L182]
> It will be good to restore DECIMAL_64 support in iceberg input format.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
