[
https://issues.apache.org/jira/browse/HIVE-26407?focusedWorklogId=801444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801444
]
ASF GitHub Bot logged work on HIVE-26407:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/22 16:48
Start Date: 17/Aug/22 16:48
Worklog Time Spent: 10m
Work Description: InvisibleProgrammer commented on code in PR #3489:
URL: https://github.com/apache/hive/pull/3489#discussion_r948194918
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -86,6 +81,8 @@ public class Worker extends RemoteCompactorThread implements
MetaStoreThread {
private String workerName;
+ protected StatsUpdater statsUpdater;
Review Comment:
Yes, thx.
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java:
##########
@@ -168,6 +170,8 @@ public void setup() throws Exception {
}
}
createTestDataFile(BASIC_FILE_NAME, input);
+
+ statsUpdater = new StatsUpdater();
Review Comment:
Sure.
Issue Time Tracking
-------------------
Worklog Id: (was: 801444)
Time Spent: 2h 50m (was: 2h 40m)
> Do not collect statistics if the compaction fails
> -------------------------------------------------
>
> Key: HIVE-26407
> URL: https://issues.apache.org/jira/browse/HIVE-26407
> Project: Hive
> Issue Type: Test
> Components: Hive
> Reporter: Zsolt Miskolczi
> Assignee: Zsolt Miskolczi
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> It can still compute statistics, even if compaction fails.
> if (computeStats) \{
> StatsUpdater.gatherStats(ci, conf, runJobAsSelf(ci.runAs) ? ci.runAs :
> t1.getOwner(),
> CompactorUtil.getCompactorJobQueueName(conf, ci, t1));
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
