[ 
https://issues.apache.org/jira/browse/HIVE-26407?focusedWorklogId=801445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801445
 ]

ASF GitHub Bot logged work on HIVE-26407:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Aug/22 16:49
            Start Date: 17/Aug/22 16:49
    Worklog Time Spent: 10m 
      Work Description: InvisibleProgrammer commented on code in PR #3489:
URL: https://github.com/apache/hive/pull/3489#discussion_r948195158


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/StatsUpdater.java:
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.txn.compactor;
+
+import org.apache.hadoop.hive.common.ValidTxnList;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.Warehouse;
+import org.apache.hadoop.hive.metastore.txn.CompactionInfo;
+import org.apache.hadoop.hive.ql.DriverUtils;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hadoop.hive.ql.stats.StatsUtils;
+import org.apache.tez.dag.api.TezConfiguration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+
+final public class StatsUpdater {

Review Comment:
   Fixed, thx.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 801445)
    Time Spent: 3h  (was: 2h 50m)

> Do not collect statistics if the compaction fails
> -------------------------------------------------
>
>                 Key: HIVE-26407
>                 URL: https://issues.apache.org/jira/browse/HIVE-26407
>             Project: Hive
>          Issue Type: Test
>          Components: Hive
>            Reporter: Zsolt Miskolczi
>            Assignee: Zsolt Miskolczi
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> It can still compute statistics, even if compaction fails.
> if (computeStats) \{
>   StatsUpdater.gatherStats(ci, conf, runJobAsSelf(ci.runAs) ? ci.runAs : 
> t1.getOwner(),
>           CompactorUtil.getCompactorJobQueueName(conf, ci, t1));
> }



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to