[ 
https://issues.apache.org/jira/browse/HIVE-25934?focusedWorklogId=751736&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751736
 ]

ASF GitHub Bot logged work on HIVE-25934:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/22 18:25
            Start Date: 01/Apr/22 18:25
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r840825262



##########
File path: 
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
   3: required string tableName,
   4: required list<string> partVals,
   5: required Partition newPart,
-  6: optional string validWriteIdList
+  6: optional string validWriteIdList,
+  7: optional EnvironmentContext environmentContext

Review comment:
       By my understanding - EnvironmentContext was the first solution for 
extending the interface with new fields without adding new methods every time. 
This solution evolved to the `...Request` objects later.
   
   Since we have a `RenamePartitionRequest` already, it might be better to use 
that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 751736)
    Time Spent: 1h 50m  (was: 1h 40m)

> Non blocking RENAME PARTITION implementation
> --------------------------------------------
>
>                 Key: HIVE-25934
>                 URL: https://issues.apache.org/jira/browse/HIVE-25934
>             Project: Hive
>          Issue Type: Task
>            Reporter: Denys Kuzmenko
>            Assignee: Denys Kuzmenko
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Implement RENAME PARTITION in a way that doesn't have to wait for currently 
> running read operations to be finished.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to