[
https://issues.apache.org/jira/browse/HIVE-25934?focusedWorklogId=724583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724583
]
ASF GitHub Bot logged work on HIVE-25934:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/22 15:56
Start Date: 10/Feb/22 15:56
Worklog Time Spent: 10m
Work Description: rbalamohan commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r803827123
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
##########
@@ -448,6 +448,20 @@ public boolean renameDir(Path sourcePath, Path destPath,
boolean needCmRecycle)
return false;
}
+ public boolean copyDir(Path sourcePath, Path destPath, boolean
needCmRecycle) throws MetaException {
+ try {
+ if (needCmRecycle) {
+ cm.recycle(sourcePath, RecycleType.COPY, true);
+ }
+ FileSystem srcFs = getFs(sourcePath);
+ FileSystem destFs = getFs(destPath);
+ return FileUtils.copy(srcFs, sourcePath, destFs, destPath, false, false,
conf);
Review comment:
minor comment. This can turn out to be expensive depending on size of
the directory, size and number of files. May be good to add a TODO for later
ref/fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 724583)
Time Spent: 20m (was: 10m)
> Non blocking RENAME PARTITION implementation
> --------------------------------------------
>
> Key: HIVE-25934
> URL: https://issues.apache.org/jira/browse/HIVE-25934
> Project: Hive
> Issue Type: Task
> Reporter: Denys Kuzmenko
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Implement RENAME PARTITION in a way that doesn't have to wait for currently
> running read operations to be finished.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
