[
https://issues.apache.org/jira/browse/HIVE-25943?focusedWorklogId=735856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735856
]
ASF GitHub Bot logged work on HIVE-25943:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/22 10:51
Start Date: 03/Mar/22 10:51
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on a change in pull request #3034:
URL: https://github.com/apache/hive/pull/3034#discussion_r818536645
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3318,6 +3318,10 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
HIVE_COMPACTOR_CLEANER_RETENTION_TIME("hive.compactor.cleaner.retention.time.seconds",
"300s",
new TimeValidator(TimeUnit.SECONDS), "Time to wait before cleanup of
obsolete files/dirs after compaction. \n"
+ "This is the minimum amount of time the system will wait, since it
will not clean before all open transactions are committed, that were opened
before the compaction"),
+
HIVE_COMPACTOR_CLEANER_MAX_RETRY_ATTEMPTS("hive.compactor.cleaner.retry.maxattempts",
5,
+ new RangeValidator(0, 10), "Maximum number of attempts to clean a
table again after a " +
+ "failed cycle. The delay has a backoff, and calculated the
following way: " +
+ "pow(2, number_of_failed_attempts) *
HIVE_COMPACTOR_CLEANER_RETENTION_TIME. Must be between 0 and 10"),
Review comment:
Separating retry retention time from the delayed start retention time
makes sense. However I would keep the backoff algorithm to wait more and more
time before retrying failed clean attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 735856)
Time Spent: 4h 10m (was: 4h)
> Introduce compaction cleaner failed attempts threshold
> ------------------------------------------------------
>
> Key: HIVE-25943
> URL: https://issues.apache.org/jira/browse/HIVE-25943
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> If the cleaner fails for some reason, the compaction entity status remains in
> "ready for cleaning", therefore the cleaner will pick up this entity
> resulting in an endless try. The number of failed cleaning attempts should be
> counted and if they reach a certain threshold the cleaner must skip all the
> cleaning attempts on that compaction entity.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
