[
https://issues.apache.org/jira/browse/HIVE-25943?focusedWorklogId=731434&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731434
]
ASF GitHub Bot logged work on HIVE-25943:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/22 08:48
Start Date: 23/Feb/22 08:48
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #3034:
URL: https://github.com/apache/hive/pull/3034#discussion_r812666282
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -78,21 +77,22 @@
import java.util.concurrent.ExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.concurrent.atomic.AtomicInteger;
import java.util.stream.Collectors;
import static
org.apache.hadoop.hive.conf.Constants.COMPACTOR_CLEANER_THREAD_NAME_FORMAT;
+import static
org.apache.hadoop.hive.conf.HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_MAX_RETRY_ATTEMPTS;
import static
org.apache.hadoop.hive.conf.HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_RETENTION_TIME;
import static
org.apache.hadoop.hive.conf.HiveConf.ConfVars.HIVE_COMPACTOR_DELAYED_CLEANUP_ENABLED;
import static org.apache.hadoop.hive.metastore.HMSHandler.getMSForConf;
import static
org.apache.hadoop.hive.metastore.utils.MetaStoreUtils.getDefaultCatalog;
-import com.codahale.metrics.Counter;
-
/**
* A class to clean directories after compactions. This will run in a
separate thread.
*/
public class Cleaner extends MetaStoreCompactorThread {
+
+ static final String CURRENT_CLEANER_RETRY_ATTEMPTS =
"hive.compactor.cleaner.retry.currentattempts";
Review comment:
I didn't say we need to create a new one, rather reuse an existing one,
however, as I can see config defined in HiveConf is used to set the max
attempts. closing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 731434)
Time Spent: 3h 40m (was: 3.5h)
> Introduce compaction cleaner failed attempts threshold
> ------------------------------------------------------
>
> Key: HIVE-25943
> URL: https://issues.apache.org/jira/browse/HIVE-25943
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> If the cleaner fails for some reason, the compaction entity status remains in
> "ready for cleaning", therefore the cleaner will pick up this entity
> resulting in an endless try. The number of failed cleaning attempts should be
> counted and if they reach a certain threshold the cleaner must skip all the
> cleaning attempts on that compaction entity.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
