[
https://issues.apache.org/jira/browse/HIVE-25953?focusedWorklogId=730823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-730823
]
ASF GitHub Bot logged work on HIVE-25953:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/22 11:43
Start Date: 22/Feb/22 11:43
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #3033:
URL: https://github.com/apache/hive/pull/3033#discussion_r811856166
##########
File path: ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
##########
@@ -491,25 +484,25 @@ STAGE PLANS:
aggregations: count(VALUE._col0)
mode: mergepartial
outputColumnNames: _col0
- Statistics: Num rows: 1 Data size: 196 Basic stats: COMPLETE
Column stats: NONE
- Limit
- Number of rows: 0
- Statistics: Num rows: 0 Data size: 0 Basic stats: COMPLETE
Column stats: NONE
+ Statistics: Num rows: 1 Data size: 192 Basic stats: COMPLETE
Column stats: NONE
+ Filter Operator
+ predicate: sq_count_check(_col0) (type: boolean)
+ Statistics: Num rows: 1 Data size: 192 Basic stats: COMPLETE
Column stats: NONE
Review comment:
It would be nice to understand why these changes happen.
##########
File path: ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
##########
@@ -420,34 +420,27 @@ STAGE PLANS:
TableScan
alias: part_null_n0
filterExpr: p_name is null (type: boolean)
- Statistics: Num rows: 1 Data size: 188 Basic stats: COMPLETE
Column stats: NONE
+ Statistics: Num rows: 1 Data size: 184 Basic stats: COMPLETE
Column stats: NONE
Filter Operator
predicate: p_name is null (type: boolean)
- Statistics: Num rows: 1 Data size: 188 Basic stats:
COMPLETE Column stats: NONE
+ Statistics: Num rows: 1 Data size: 184 Basic stats:
COMPLETE Column stats: NONE
Select Operator
- expressions: p_partkey (type: int)
- outputColumnNames: p_partkey
- Statistics: Num rows: 1 Data size: 188 Basic stats:
COMPLETE Column stats: NONE
+ Statistics: Num rows: 1 Data size: 184 Basic stats:
COMPLETE Column stats: NONE
+ Reduce Output Operator
+ null sort order:
+ sort order:
+ Statistics: Num rows: 1 Data size: 184 Basic stats:
COMPLETE Column stats: NONE
Group By Operator
- aggregations: count(p_partkey)
+ aggregations: count()
minReductionHashAggr: 0.99
mode: hash
outputColumnNames: _col0
- Statistics: Num rows: 1 Data size: 196 Basic stats:
COMPLETE Column stats: NONE
+ Statistics: Num rows: 1 Data size: 192 Basic stats:
COMPLETE Column stats: NONE
Reduce Output Operator
null sort order:
sort order:
- Statistics: Num rows: 1 Data size: 196 Basic stats:
COMPLETE Column stats: NONE
+ Statistics: Num rows: 1 Data size: 192 Basic stats:
COMPLETE Column stats: NONE
value expressions: _col0 (type: bigint)
- Limit
- Number of rows: 0
- Statistics: Num rows: 0 Data size: 0 Basic stats:
COMPLETE Column stats: NONE
- Select Operator
- Statistics: Num rows: 0 Data size: 0 Basic stats: NONE
Column stats: NONE
- Reduce Output Operator
- null sort order:
- sort order:
- Statistics: Num rows: 0 Data size: 0 Basic stats:
NONE Column stats: NONE
Review comment:
Is it ok that this limit goes away? Do we understand why this happened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 730823)
Time Spent: 0.5h (was: 20m)
> Drop HiveRelMdPredicates::getPredicates(Join...) to use that of
> RelMdPredicates
> -------------------------------------------------------------------------------
>
> Key: HIVE-25953
> URL: https://issues.apache.org/jira/browse/HIVE-25953
> Project: Hive
> Issue Type: Sub-task
> Components: CBO
> Affects Versions: 4.0.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The goal of the ticket is to unify the two implementations and remove the
> override in HiveRelMdPredicates.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
