[ 
https://issues.apache.org/jira/browse/HIVE-25829?focusedWorklogId=706048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706048
 ]

ASF GitHub Bot logged work on HIVE-25829:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/22 12:27
            Start Date: 10/Jan/22 12:27
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on a change in pull request #2911:
URL: https://github.com/apache/hive/pull/2911#discussion_r781148223



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
##########
@@ -195,20 +196,31 @@ public static void 
updateJobCredentialProviders(Configuration jobConf) {
           + " previous location was " + oldKeyStoreLocation);
     }
 
+    updateCredentialProviderPasswordForJobs(jobConf);
+  }
+
+  public static void updateCredentialProviderPasswordForJobs(Configuration 
jobConf) {
     String credstorePassword = getJobCredentialProviderPassword(jobConf);
     if (credstorePassword != null) {
       String execEngine = jobConf.get(ConfVars.HIVE_EXECUTION_ENGINE.varname);
 
-      if ("mr".equalsIgnoreCase(execEngine)) {
-        // if the execution engine is MR set the map/reduce env with the 
credential store password
-
+      if ("mr".equalsIgnoreCase(execEngine) || 
"tez".equalsIgnoreCase(execEngine)) {

Review comment:
       do we have enums for the execution engines?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 706048)
    Time Spent: 50m  (was: 40m)

> Tez exec mode support for credential provider for jobs
> ------------------------------------------------------
>
>                 Key: HIVE-25829
>                 URL: https://issues.apache.org/jira/browse/HIVE-25829
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>            Reporter: Ádám Szita
>            Assignee: László Bodor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> HIVE-14822 introduced support to securely forward a job specific java 
> credential store path, and a corresponding password to the backend executors. 
> This is currently implemented for only MR2 and Spark execution engines. I 
> propose we extend this feature by adding Tez mode to said list.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to