[
https://issues.apache.org/jira/browse/HIVE-25829?focusedWorklogId=703215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-703215
]
ASF GitHub Bot logged work on HIVE-25829:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/22 08:02
Start Date: 04/Jan/22 08:02
Worklog Time Spent: 10m
Work Description: abstractdog commented on a change in pull request #2911:
URL: https://github.com/apache/hive/pull/2911#discussion_r777886508
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
##########
@@ -199,16 +199,16 @@ public static void
updateJobCredentialProviders(Configuration jobConf) {
if (credstorePassword != null) {
String execEngine = jobConf.get(ConfVars.HIVE_EXECUTION_ENGINE.varname);
- if ("mr".equalsIgnoreCase(execEngine)) {
- // if the execution engine is MR set the map/reduce env with the
credential store password
+ if ("mr".equalsIgnoreCase(execEngine) ||
"tez".equalsIgnoreCase(execEngine)) {
+ // if the execution engine is MR/Tez set the map/reduce env with the
credential store password
Collection<String> redactedProperties =
jobConf.getStringCollection(MRJobConfig.MR_JOB_REDACTED_PROPERTIES);
-
Stream.of(
JobConf.MAPRED_MAP_TASK_ENV,
JobConf.MAPRED_REDUCE_TASK_ENV,
- MRJobConfig.MR_AM_ADMIN_USER_ENV)
+ MRJobConfig.MR_AM_ADMIN_USER_ENV,
+ "tez.am.launch.env")
Review comment:
thanks @nareshpr, I'll double-check, I tested this patch on a cluster as
a POC, and I saw a simple map/reduce dag worked
also, I'm going to decide how to use this as referring to
TezConfiguration.TEZ_AM_LAUNCH_ENV, which is not visible currently in
hive-common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 703215)
Time Spent: 0.5h (was: 20m)
> Tez exec mode support for credential provider for jobs
> ------------------------------------------------------
>
> Key: HIVE-25829
> URL: https://issues.apache.org/jira/browse/HIVE-25829
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Ádám Szita
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HIVE-14822 introduced support to securely forward a job specific java
> credential store path, and a corresponding password to the backend executors.
> This is currently implemented for only MR2 and Spark execution engines. I
> propose we extend this feature by adding Tez mode to said list.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
