[ 
https://issues.apache.org/jira/browse/HIVE-24445?focusedWorklogId=699336&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-699336
 ]

ASF GitHub Bot logged work on HIVE-24445:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Dec/21 12:48
            Start Date: 21/Dec/21 12:48
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2772:
URL: https://github.com/apache/hive/pull/2772#discussion_r773107563



##########
File path: 
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
##########
@@ -363,8 +366,14 @@ public Path getDefaultTablePath(Database db, String 
tableName, boolean isExterna
     } else {
       dbPath = getDatabaseManagedPath(db);
     }
-    return getDnsPath(
-        new Path(dbPath, 
MetaStoreUtils.encodeTableName(tableName.toLowerCase())));
+    if (!isExternal && tableName.matches("(.*)" + V_TABLE_PATTERN)) {

Review comment:
       nit: Maybe a comment, or a different String value, since this is not a 
`tableName`. This is `tablePath`? Strings are always recreated anyway, so there 
is not performance loss, but I think it would be easier to understand the code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 699336)
    Time Spent: 13h 10m  (was: 13h)

> Non blocking DROP TABLE implementation
> --------------------------------------
>
>                 Key: HIVE-24445
>                 URL: https://issues.apache.org/jira/browse/HIVE-24445
>             Project: Hive
>          Issue Type: New Feature
>          Components: Hive
>            Reporter: Zoltan Chovan
>            Assignee: Denys Kuzmenko
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 13h 10m
>  Remaining Estimate: 0h
>
> Implement a way to execute drop table operations in a way that doesn't have 
> to wait for currently running read operations to be finished.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to