[
https://issues.apache.org/jira/browse/HIVE-24445?focusedWorklogId=697815&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-697815
]
ASF GitHub Bot logged work on HIVE-24445:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/21 10:26
Start Date: 17/Dec/21 10:26
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2772:
URL: https://github.com/apache/hive/pull/2772#discussion_r771280308
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/DropTableAnalyzer.java
##########
@@ -51,7 +55,14 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
Table table = getTable(tableName, throwException);
if (table != null) {
inputs.add(new ReadEntity(table));
- outputs.add(new WriteEntity(table, WriteEntity.WriteType.DDL_EXCLUSIVE));
+
+ boolean tableWithSuffix = (HiveConf.getBoolVar(conf,
ConfVars.HIVE_ACID_CREATE_TABLE_USE_SUFFIX)
+ || HiveConf.getBoolVar(conf,
ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED))
+ && AcidUtils.isTransactionalTable(table)
+ && table.getSd().getLocation().matches(V_TABLE_PATTERN);
Review comment:
Might have issues with legacy tables with where the name (and location)
ends with `_v1`.
Would it cause problems?
- Say I have an old table users_v2
- Switch on the `HIVE_ACID_CREATE_TABLE_USE_SUFFIX`
- Drop the table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 697815)
Time Spent: 12h (was: 11h 50m)
> Non blocking DROP TABLE implementation
> --------------------------------------
>
> Key: HIVE-24445
> URL: https://issues.apache.org/jira/browse/HIVE-24445
> Project: Hive
> Issue Type: New Feature
> Components: Hive
> Reporter: Zoltan Chovan
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 12h
> Remaining Estimate: 0h
>
> Implement a way to execute drop table operations in a way that doesn't have
> to wait for currently running read operations to be finished.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
