[
https://issues.apache.org/jira/browse/HIVE-25792?focusedWorklogId=696403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696403
]
ASF GitHub Bot logged work on HIVE-25792:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/21 07:15
Start Date: 15/Dec/21 07:15
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2865:
URL: https://github.com/apache/hive/pull/2865#discussion_r769314437
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/reexec/IReExecutionPlugin.java
##########
@@ -42,24 +42,72 @@
/**
* Called before executing the query.
*/
- void beforeExecute(int executionIndex, boolean explainReOptimization);
+ default void beforeExecute(int executionIndex, boolean
explainReOptimization) {
+ // default noop
+ }
/**
* The query have failed, does this plugin advises to re-execute it again?
*/
- boolean shouldReExecute(int executionNum);
+ default boolean shouldReExecute(int executionNum) {
+ // default no
+ return false;
+ }
/**
- * The plugin should prepare for the re-compilaton of the query.
+ * The plugin should prepare for the re-compilation of the query.
*/
- void prepareToReExecute();
+ default void prepareToReExecute() {
+ // default noop
+ }
/**
- * The query have failed; and have been recompiled - does this plugin
advises to re-execute it again?
+ * The query has failed; and have been recompiled - does this plugin advises
to re-execute it again?
*/
- boolean shouldReExecute(int executionNum, PlanMapper oldPlanMapper,
PlanMapper newPlanMapper);
+ default boolean shouldReExecute(int executionNum, PlanMapper oldPlanMapper,
PlanMapper newPlanMapper) {
Review comment:
Keeping as discussed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 696403)
Time Spent: 3h 10m (was: 3h)
> Multi Insert query fails on CBO path
> -------------------------------------
>
> Key: HIVE-25792
> URL: https://issues.apache.org/jira/browse/HIVE-25792
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> {code}
> set hive.cbo.enable=true;
> drop table if exists aa1;
> drop table if exists bb1;
> drop table if exists cc1;
> drop table if exists dd1;
> drop table if exists ee1;
> drop table if exists ff1;
> create table aa1 ( stf_id string);
> create table bb1 ( stf_id string);
> create table cc1 ( stf_id string);
> create table ff1 ( x string);
> explain
> from ff1 as a join cc1 as b
> insert overwrite table aa1 select stf_id GROUP BY b.stf_id
> insert overwrite table bb1 select b.stf_id GROUP BY b.stf_id
> ;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
