[
https://issues.apache.org/jira/browse/HIVE-25792?focusedWorklogId=696404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696404
]
ASF GitHub Bot logged work on HIVE-25792:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/21 07:15
Start Date: 15/Dec/21 07:15
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2865:
URL: https://github.com/apache/hive/pull/2865#discussion_r769314666
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecutionCBOPlugin.java
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.reexec;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.Driver;
+import org.apache.hadoop.hive.ql.hooks.QueryLifeTimeHook;
+import org.apache.hadoop.hive.ql.hooks.QueryLifeTimeHookContext;
+import org.apache.hadoop.hive.ql.parse.CBOException;
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+
+/**
+ * Re-compiles the query without CBO
+ */
+public class ReExecutionCBOPlugin implements IReExecutionPlugin {
+
+ private Driver driver;
+ private boolean retryPossible = false;
+ private CBOFallbackStrategy fallbackStrategy;
+
+ class LocalHook implements QueryLifeTimeHook {
+ @Override
+ public void beforeCompile(QueryLifeTimeHookContext ctx) {
+ // noop
+ }
+
+ @Override
+ public void afterCompile(QueryLifeTimeHookContext ctx, boolean hasError) {
+ if (hasError) {
+ Throwable throwable = ctx.getHookContext().getException();
+ if (throwable != null) {
+ if (throwable instanceof CBOException) {
+ // Determine if we should re-throw the exception OR if we retry
planning with non-CBO.
+ if (fallbackStrategy.isFatal((CBOException) throwable)) {
+ Throwable cause = throwable.getCause();
+ if (cause instanceof RuntimeException || cause instanceof
SemanticException) {
+ // These types of exceptions do not need wrapped
+ retryPossible = false;
+ return;
+ }
+ // Wrap all other errors (Should only hit in tests)
+ throw new RuntimeException(cause);
+ } else {
+ // Only if the exception is a CBOException then we can retry
+ retryPossible = true;
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 696404)
Time Spent: 3h 20m (was: 3h 10m)
> Multi Insert query fails on CBO path
> -------------------------------------
>
> Key: HIVE-25792
> URL: https://issues.apache.org/jira/browse/HIVE-25792
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> {code}
> set hive.cbo.enable=true;
> drop table if exists aa1;
> drop table if exists bb1;
> drop table if exists cc1;
> drop table if exists dd1;
> drop table if exists ee1;
> drop table if exists ff1;
> create table aa1 ( stf_id string);
> create table bb1 ( stf_id string);
> create table cc1 ( stf_id string);
> create table ff1 ( x string);
> explain
> from ff1 as a join cc1 as b
> insert overwrite table aa1 select stf_id GROUP BY b.stf_id
> insert overwrite table bb1 select b.stf_id GROUP BY b.stf_id
> ;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
