[
https://issues.apache.org/jira/browse/HIVE-25610?focusedWorklogId=680293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680293
]
ASF GitHub Bot logged work on HIVE-25610:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/21 14:15
Start Date: 11/Nov/21 14:15
Worklog Time Spent: 10m
Work Description: kasakrisz opened a new pull request #2778:
URL: https://github.com/apache/hive/pull/2778
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Add the following constants to `serde/if/serde.thrift`
```
const string LIST_COLUMN_COMMENTS = "columns.comments";
const string LIST_PARTITION_COLUMN_COMMENTS = "partition.columns.comments";
```
### Why are the changes needed?
Constants are introduced in #2715 but not added to `serde.thrift`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local -Drat.skip
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 680293)
Time Spent: 2.5h (was: 2h 20m)
> Handle partition field comments for Iceberg tables
> --------------------------------------------------
>
> Key: HIVE-25610
> URL: https://issues.apache.org/jira/browse/HIVE-25610
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently partition comments are not sent to Iceberg during table creation.
> Also {{AbstractSerDe}} provides methods to parse the column related fields
> from the properties. We should reuse them whenever possible.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
