[
https://issues.apache.org/jira/browse/HIVE-25610?focusedWorklogId=664993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664993
]
ASF GitHub Bot logged work on HIVE-25610:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/21 18:34
Start Date: 13/Oct/21 18:34
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2715:
URL: https://github.com/apache/hive/pull/2715#discussion_r727342014
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -231,44 +223,28 @@ public ObjectInspector getObjectInspector() {
/**
* Gets the hive schema from the serDeProperties, and throws an exception if
it is not provided. In the later case
Review comment:
Looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 664993)
Time Spent: 2h 10m (was: 2h)
> Handle partition field comments for Iceberg tables
> --------------------------------------------------
>
> Key: HIVE-25610
> URL: https://issues.apache.org/jira/browse/HIVE-25610
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently partition comments are not sent to Iceberg during table creation.
> Also {{AbstractSerDe}} provides methods to parse the column related fields
> from the properties. We should reuse them whenever possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
